Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove incomplete artifactory task #6857

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

usmansaleem
Copy link
Member

PR description

build: Remove incomplete artifactory task. The top level artifactory task was used to upload dists to artifactory which has been moved to GH

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

The top level artifactory task was used to upload dists to artifactory which has been moved to GH

Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem requested a review from jflo April 2, 2024 01:37
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
@jflo jflo merged commit 42bc850 into hyperledger:main Apr 2, 2024
42 checks passed
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* build: Remove incomplete artifactory task
The top level artifactory task was used to upload dists to artifactory which has been moved to GH

* build: Adding back top level publishing task

---------

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* build: Remove incomplete artifactory task
The top level artifactory task was used to upload dists to artifactory which has been moved to GH

* build: Adding back top level publishing task

---------

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: amsmota <antonio.mota@citi.com>
@usmansaleem usmansaleem deleted the fix_artifactory_pub branch May 3, 2024 05:14
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* build: Remove incomplete artifactory task
The top level artifactory task was used to upload dists to artifactory which has been moved to GH

* build: Adding back top level publishing task

---------

Signed-off-by: Usman Saleem <usman@usmans.info>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 7, 2024
* build: Remove incomplete artifactory task
The top level artifactory task was used to upload dists to artifactory which has been moved to GH

* build: Adding back top level publishing task

---------

Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants